This repository has been archived by the owner on Jul 29, 2019. It is now read-only.
Add edge styles support for DOT lib #3348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update for TODO: support of solid/dotted/dashed edges (attr = 'style') * Edge styles are defined as var edgeStyles in parseAttributeList().
Add an editable example for playing DOT edge styles
wimrijnders
suggested changes
Aug 15, 2017
* Correct typo of filename from 'dotEdgeSytles.html' to 'dotEdgeStyles.html'. * Remove TODO description of the issue for edge style
|
Thank you for reviewing and comments! I fixed it and please check my update. |
wimrijnders
approved these changes
Aug 17, 2017
primozs
pushed a commit
to primozs/vis
that referenced
this pull request
Jan 3, 2019
* Add support for edge style * Update for TODO: support of solid/dotted/dashed edges (attr = 'style') * Edge styles are defined as var edgeStyles in parseAttributeList(). * Add example for edge styles Add an editable example for playing DOT edge styles * Correct typo and remove TODO description * Correct typo of filename from 'dotEdgeSytles.html' to 'dotEdgeStyles.html'. * Remove TODO description of the issue for edge style
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update for TODO: support of solid/dotted/dashed edges (attr = 'style') in lib/network/dotparser.js
dotparser.js does not support edge styles and this feature is described as TODO
I have added edge styles (solid, dashed and dotted) and an example examples/network/data/dotLanguage/dotEdgeSytles.html
Changes
Update dotparser.js
Add edge style definition in parseAttributeList().
Create dotEdgeSytles.html
For testing edge styles. It is based on examples/network/data/dotLanguage/dotPlayground.html.